Heap Buffer Overflow via Incomplete Length Check in `Crypto_TC_ApplySecurity`

Vulnerability Description

CryptoLib provides a software-only solution using the CCSDS Space Data Link Security Protocol - Extended Procedures (SDLS-EP) to secure communications between a spacecraft running the core Flight System (cFS) and a ground station. In 1.3.3 and earlier, a heap buffer overflow vulnerability persists in the Crypto_TC_ApplySecurity function due to an incomplete validation check on the fl (frame length) field. Although CVE-2025-29912 addressed an underflow issue involving fl, the patch fails to fully prevent unsafe calculations. As a result, an attacker can still craft malicious frames that cause a negative tf_payload_len, which is then interpreted as a large unsigned value, leading to a heap buffer overflow in a memcpy call.

References

• https://github.com/nasa/CryptoLib/security/advisories/GHSA-6w2x-w7w3-85w2
• https://github.com/nasa/CryptoLib/commit/59d1bce7608c94c6131ef4877535075b0649799c