Unrestricted file upload leading to privilege escalation in act

Vulnerability Description

act is a project which allows for local running of github actions. The artifact server that stores artifacts from Github Action runs does not sanitize path inputs. This allows an attacker to download and overwrite arbitrary files on the host from a Github Action. This issue may lead to privilege escalation. The /upload endpoint is vulnerable to path traversal as filepath is user controlled, and ultimately flows into os.Mkdir and os.Open. The /artifact endpoint is vulnerable to path traversal as the path is variable is user controlled, and the specified file is ultimately returned by the server. This has been addressed in version 0.2.40. Users are advised to upgrade. Users unable to upgrade may, during implementation of Open and OpenAtEnd for FS, ensure to use ValidPath() to check against path traversal or clean the user-provided paths manually.

References

• https://github.com/nektos/act/security/advisories/GHSA-pc99-qmg4-rcff
• https://github.com/nektos/act/issues/1553
• https://github.com/nektos/act/commit/63ae215071f94569d910964bdee866d91d6e3a10
• https://github.com/nektos/act/blob/master/pkg/artifacts/server.go#L65
• https://github.com/nektos/act/blob/v0.2.35/pkg/artifacts/server.go#L245
• https://github.com/nektos/act/blob/v0.2.35/pkg/artifacts/server.go#LL103C2-L103C2
• https://securitylab.github.com/advisories/GHSL-2023-004_act/