External URLs for Deployments can include javascript in argo-cd

Vulnerability Description

Argo CD is a declarative, GitOps continuous delivery tool for Kubernetes. All versions of Argo CD starting with v1.0.0 are vulnerable to a cross-site scripting (XSS) bug allowing a malicious user to inject a `javascript:` link in the UI. When clicked by a victim user, the script will execute with the victim's permissions (up to and including admin). The script would be capable of doing anything which is possible in the UI or via the API, such as creating, modifying, and deleting Kubernetes resources. A patch for this vulnerability has been released in the following Argo CD versions: v2.4.1, v2.3.5, v2.2.10 and v2.1.16. There are no completely-safe workarounds besides upgrading.

References

• https://github.com/argoproj/argo-cd/security/advisories/GHSA-h4w9-6x78-8vrj
• https://github.com/argoproj/argo-cd/commit/8bc3ef690de29c68a36f473908774346a44d4038
• https://argo-cd.readthedocs.io/en/stable/user-guide/external-url/